Skip to content

fix(trino): Bugfixes & QoL changes - #311

Merged
labrenbe merged 8 commits into
mainfrom
fix/various-fixes-qol-changes
Sep 9, 2026
Merged

fix(trino): Bugfixes & QoL changes#311
labrenbe merged 8 commits into
mainfrom
fix/various-fixes-qol-changes

Conversation

@labrenbe

@labrenbe labrenbe commented Sep 7, 2026

Copy link
Copy Markdown
Member

User-feedback fixes and QoL improvements for the Trino module.

Fixed

  • Catalog browser now scrolls long schema lists (was clipped after ~30 entries).
  • Queries stopped at the 10,000-row limit now actually cancel in Trino — via the client-protocol DELETE nextUri instead of the kill-query-gated DELETE /v1/query/{id}.
  • Cancellation and polling now send X-Trino-User when impersonation is enabled (previously ran as the service principal).
  • Saving a Trino connection now verifies it (SELECT 1, 10 s timeout) before storing, instead of always reporting success.
  • Transport-level query failures now show the reason instead of a bare "Failed" badge.
  • Fixed a silent unhandled rejection when the catalog default-schema dropdown failed to load.
  • Long catalog names now truncate instead of overflowing horizontally.

Added

  • trino.publicUrl: separate browser-facing URL for the "View in Trino" deep link (falls back to trino.url); wired through the Helm chart.
  • Resizable catalog browser with a persisted, keyboard-adjustable width.

Tests

  • Unit: cancelViaUri, impersonation headers, AbortSignal forwarding, resolveTrinoPublicUrl, row-limit cancel.
  • E2E: catalog scroll + resize, transport-error surfacing.

@labrenbe
labrenbe requested a review from dervoeti September 7, 2026 13:59
@labrenbe labrenbe self-assigned this Sep 7, 2026
Comment thread src/routes/(app)/trino/+page.server.ts Outdated
Comment thread src/lib/server/trino/client.ts
@dervoeti dervoeti moved this to Development: In Review in Stackable Engineering Sep 8, 2026
@labrenbe
labrenbe merged commit 6843789 into main Sep 9, 2026
12 checks passed
@labrenbe
labrenbe deleted the fix/various-fixes-qol-changes branch September 9, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: In Review

Development

Successfully merging this pull request may close these issues.

2 participants